Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12143#issuecomment-205978731
Awesome :) A few minor things found while reviewing:
One thing I noticed while looking at the differences between the code we
are deleting and the code we are keeping is that some of the code we are
deleting had a some useful javadoc on how to run the example and where it was
from (e.g. `JavaTrainValidationSplitExample.java`) we might want to copy over.
Also I think the reference for what
`JavaSimpleTextClassificationPipeline.java` duplicated is pointing to the wrong
file since it doesn't do the cross validator stuff (although it looks like the
cross validator is a super set so maybe its ok to kill anyways - but if we do
kill it we should probably rename the new to include something like
"WithTextClassificationPipeline" one so people looking for a sample text
pipeline
can still find it)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
