Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/12078#discussion_r58617810 --- Diff: core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala --- @@ -41,7 +41,8 @@ private[spark] class CoarseGrainedExecutorBackend( executorId: String, cores: Int, userClassPath: Seq[URL], - env: SparkEnv) + env: SparkEnv, + hostname: String) --- End diff -- @XuTingjun Before this patch, the hostname was set by CoarseGrainedSchedulerBackend. But now, it just uses the specified one. It would crease some problem. E.g., if the specified `hostname` is `0.0.0.0`, `Utils.localHostName/localHostNameForURI` may not work correctly as it doesn't return a real host or ip.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org