Github user nongli commented on the pull request:
https://github.com/apache/spark/pull/10628#issuecomment-205993243
I don't think it should be needed for OnHeap (it uses Platform.getInt which
I think should work for both). For offheap, as far as I know, only a few of the
puts that take byte[] as input would care. Subclassing or if(...) both sound
fine to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
