Github user sameeragarwal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12103#discussion_r58618637
  
    --- Diff: 
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java
 ---
    @@ -232,6 +234,96 @@ public MapData getMap(int ordinal) {
         public Object get(int ordinal, DataType dataType) {
           throw new NotImplementedException();
         }
    +
    +    @Override
    +    public void update(int ordinal, Object value) {
    --- End diff --
    
    yes, this shouldn't be on the hot path. It was just a method that needed to 
be overridden while implementing `MutableRow`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to