GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/12188
Add thread-safe comments for CoarseGrainedSchedulerBackend's fields
## What changes were proposed in this pull request?
While I was reviewing #12078, I found most of
CoarseGrainedSchedulerBackend's mutable fields doesn't have any comments about
the thread-safe assumptions and it's hard for people to figure out which part
of codes should be protected by the lock. This PR just added
comments/annotations for them and also added strict access modifiers for some
fields.
## How was this patch tested?
Existing unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zsxwing/spark comments
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12188.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12188
----
commit 837988f539a4439b35f7e06d753a14b5a3f75ecf
Author: Shixiong Zhu <shixi...@databricks.com>
Date: 2016-04-05T23:22:01Z
Add thread-safe comments for CoarseGrainedSchedulerBackend's fields
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
