GitHub user tejasapatil opened a pull request: https://github.com/apache/spark/pull/12194
[SPARK-14400] [SQL] ScriptTransformation does not fail the job for bad user command ## What changes were proposed in this pull request? - Refer to the Jira for the problem: jira : https://issues.apache.org/jira/browse/SPARK-14400 - The fix is to check if the process has exited with a non-zero exit code in `hasNext()`. I have moved this and checking of writer thread exception to a separate method. ## How was this patch tested? - Ran a job which had incorrect transform script command and saw that the job fails - Existing unit tests for `ScriptTransformationSuite`. Added a new unit test You can merge this pull request into a Git repository by running: $ git pull https://github.com/tejasapatil/spark script_transform Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/12194.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12194 ---- commit f9218010ae940b25d37746383b8ceb6cfc1cc59d Author: Tejas Patil <tej...@fb.com> Date: 2016-04-06T01:53:14Z - Moved the failure check to a method - Added test case commit df48e1e27e0ab569a863da2f9f79cddcbee8169b Author: Tejas Patil <tej...@fb.com> Date: 2016-04-06T01:56:10Z Removed unwanted changes ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org