Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12020#issuecomment-206502532
To clarify: I think it is OK to have save/load examples in the doc tests,
but if a test has significant validity testing, then it is better to put it in
a unit test.
This LGTM
Thanks a lot @yinxusen and @holdenk for helping to review!
Merging with master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
