Github user dhruve commented on a diff in the pull request:
https://github.com/apache/spark/pull/12115#discussion_r58777580
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -819,12 +819,22 @@ private[spark] class Client(
javaOpts += "-XX:CMSIncrementalDutyCycle=10"
}
- // Include driver-specific java options if we are launching a driver
- if (isClusterMode) {
--- End diff --
We have introduced a generic check in the SparkSubmitCommandBuilder and
SparkClassCommandBuilder which checks for Xmx settings being passed by the user
before launching the driver. Earlier changes in Client.scala have been restored
to the previous behavior where we are not making an explicit check based on the
cluster or client mode.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
