Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/12203#discussion_r58804470
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -519,8 +528,7 @@ private[spark] class Client(
).foreach { case (flist, resType, addToClasspath) =>
flist.foreach { file =>
val (_, localizedPath) = distribute(file, resType = resType)
- require(localizedPath != null)
- if (addToClasspath) {
+ if (addToClasspath && localizedPath != null) {
--- End diff --
@andrewor14 , in the previous code we assume all the files will be uploaded
into distributed cache, so this `localizedPath` should not be null. But here
with my change, some duplicated files will be neglected, this is return
`localizedPath` as null instead, so here I change to this way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
