Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12116#discussion_r58828338
--- Diff: python/pyspark/ml/regression.py ---
@@ -425,6 +425,10 @@ class DecisionTreeRegressor(JavaEstimator,
HasFeaturesCol, HasLabelCol, HasPredi
True
>>> model.depth == model2.depth
True
+ >>> isinstance(dt.setVarianceCol("varianceColTest"),
DecisionTreeRegressor)
+ True
+ >>> dt.getVarianceCol() == "varianceColTest"
+ True
--- End diff --
This is really just testing set/get of params. I think what @jkbradley was
intending is something like L414 above where
`model.transform(test1).head().prediction` checks extracting the value for
prediction col for one row. You should be able to do something similar here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
