Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/11919#discussion_r58854519
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -656,7 +656,8 @@ object ALS extends DefaultParamsReadable[ALS] with
Logging {
itemFactors.setName(s"itemFactors-$iter").persist(intermediateRDDStorageLevel)
// TODO: Generalize PeriodicGraphCheckpointer and use it here.
if (shouldCheckpoint(iter)) {
- itemFactors.checkpoint() // itemFactors gets materialized in
computeFactors.
+ // itemFactors gets materialized in computeFactors & here.
+ ALS.checkpointAndCleanParents(itemFactors)
--- End diff --
`cleanEagerly` does a `rdd.count()` - in the implicit case I believe
`itemFactors` is already materialized hence in this case we would be doing 2
counts which may be wasteful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
