Github user yongtang commented on the pull request:
https://github.com/apache/spark/pull/11989#issuecomment-206931189
Hi @MLnick, here is the complete list of the scenarios:
Real numbers (has to contain `.`), assume number of features is 15
```
.0 not allowed by regex (should not be all zeros)
.1 OK
.10 OK
0.0 not allowed by regex (should not be all zeros)
0.1 OK
0.10 OK
1.0 OK (use 15)
1.1 not allowed (greater than 1.0)
```
Integer numbers (should not container `.`), assume number of features is 15
```
0 not allowed by regex (should not be all zeros)
1 OK
...
...
15 OK
16 OK (use 15)
...
```
Let me take a look at the not allowed case and see if I could add test
cases to cover it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
