Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/12238#issuecomment-207135493 This looks good to me, although it might bake sense to batch these all up into larger changes (like we did with classification changes) rather than doing a model at a time, can @jkbradley and or @yanboliang take a look?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org