Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12217#discussion_r58964635
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -1088,8 +1088,12 @@ abstract class RDD[T: ClassTag](
partiallyAggregated = partiallyAggregated.mapPartitionsWithIndex {
(i, iter) => iter.map((i % curNumPartitions, _))
}.reduceByKey(new HashPartitioner(curNumPartitions),
cleanCombOp).values
+ // This fails:
+ // .foldByKey(zeroValue, new
HashPartitioner(curNumPartitions))(cleanCombOp).values
--- End diff --
If either of foldByKey (here) or fold (a few lines below) are used, then
the test "treeAggregate with ops modifying first args" fails---but none other
of the reduce/fold/aggregate tests fail. Any ideas on why?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
