Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12067#discussion_r58969343
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
    @@ -135,12 +175,26 @@ object DatasetBenchmark {
         benchmark.run()
     
         /*
    +    Java HotSpot(TM) 64-Bit Server VM 1.8.0_60-b27 on Mac OS X 10.11.4
    +    Intel(R) Core(TM) i7-4960HQ CPU @ 2.60GHz
         back-to-back filter:                Best/Avg Time(ms)    Rate(M/s)   
Per Row(ns)   Relative
         
-------------------------------------------------------------------------------------------
         Dataset                                   585 /  628         17.1      
    58.5       1.0X
         DataFrame                                  62 /   80        160.7      
     6.2       9.4X
         RDD                                       205 /  220         48.7      
    20.5       2.8X
         */
         benchmark2.run()
    +
    +    /*
    +    Java HotSpot(TM) 64-Bit Server VM 1.8.0_60-b27 on Mac OS X 10.11.4
    +    Intel(R) Core(TM) i7-4960HQ CPU @ 2.60GHz
    +    aggregate:                          Best/Avg Time(ms)    Rate(M/s)   
Per Row(ns)   Relative
    +    
-------------------------------------------------------------------------------------------
    +    DataFrame sum                             137 /  314         72.7      
    13.7       1.0X
    --- End diff --
    
    we need to increase the datasize by at least an order of magnitude (maybe 
even two orders of magnitude).
    
    the dataframe sum should be between 1ns - 2ns per row.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to