Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12255#discussion_r59054745
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -143,10 +143,10 @@ class SparkSqlAstBuilder extends AstBuilder {
override def visitExplain(ctx: ExplainContext): LogicalPlan =
withOrigin(ctx) {
val options = ctx.explainOption.asScala
if (options.exists(_.FORMATTED != null)) {
- logWarning("EXPLAIN FORMATTED option is ignored.")
+ logWarning("Unsupported operation: EXPLAIN FORMATTED option")
}
if (options.exists(_.LOGICAL != null)) {
--- End diff --
I think we don't need to throw an exception here. LOGICAL is more or less
the opposite of EXTENDED. So I think we can safely ignore it instead of logging
a warning or throwing an exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
