Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12248#issuecomment-207543635
Your change is about passing around a `Properties`, right? You can simply
access such an object anywhere you need to and it will be sent around as
needed. There is nothing to do actually, not even explicitly setting it as some
context property.
Your example however seems to be about configuring some global per-function
behavior, not sending props. In this example, why would the library not call
`setLogLevel` internally, either in static initialization or as needed when any
method is invoked -- why would the caller have to do it? But, how is this
helped by adding an additional `Properties` parameter?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
