Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12255#discussion_r59098761
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
    @@ -206,7 +203,7 @@ class SparkSqlAstBuilder extends AstBuilder {
       override def visitCreateTableUsing(ctx: CreateTableUsingContext): 
LogicalPlan = withOrigin(ctx) {
         val (table, temp, ifNotExists, external) = 
visitCreateTableHeader(ctx.createTableHeader)
         if (external) {
    -      logWarning("EXTERNAL option is not supported.")
    +      throw new ParseException("Unsupported operation: EXTERNAL option", 
ctx)
    --- End diff --
    
    Should we ignore it? In this case, we are creating data source tables. They 
should be `EXTERNAL`? right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to