Github user HyukjinKwon commented on the pull request:

    https://github.com/apache/spark/pull/12268#issuecomment-207694129
  
    I have two things to note.
    - It looks `buildInternalScan()` is not called but just remaining. Just in 
case I did not remove this and tested this. 
    - It looks the changes are a lot but the logics and filtering are not 
changed much except that it uses `Iterator` instead of `Reader`.
    - Performance was tested with this patch. This can be found in 
https://issues.apache.org/jira/browse/SPARK-14480.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to