Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12279#discussion_r59152083
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedColumnReader.java
---
@@ -200,8 +150,26 @@ void readBatch(int total, ColumnVector column) throws
IOException {
ColumnVector dictionaryIds = column.reserveDictionaryIds(total);
defColumn.readIntegers(
num, dictionaryIds, column, rowId, maxDefLevel,
(VectorizedValuesReader) dataColumn);
- decodeDictionaryIds(rowId, num, column, dictionaryIds);
+
+ if (column.hasDictionary() || (rowId == 0 &&
+ (descriptor.getType() == PrimitiveType.PrimitiveTypeName.INT32
||
+ descriptor.getType() == PrimitiveType.PrimitiveTypeName.INT64
||
--- End diff --
What about INT96 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
