Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12271#discussion_r59280363 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -218,14 +219,35 @@ case class CatalogTable( tableType: CatalogTableType, storage: CatalogStorageFormat, schema: Seq[CatalogColumn], - partitionColumns: Seq[CatalogColumn] = Seq.empty, - sortColumns: Seq[CatalogColumn] = Seq.empty, + partitionColumnNames: Seq[String] = Seq.empty, + sortColumnNames: Seq[String] = Seq.empty, + bucketColumnNames: Seq[String] = Seq.empty, + // e.g. (date, country) + skewColumnNames: Seq[String] = Seq.empty, + // e.g. ('2008-08-08', 'us), ('2009-09-09', 'uk') + skewColumnValues: Seq[Seq[String]] = Seq.empty, numBuckets: Int = 0, createTime: Long = System.currentTimeMillis, lastAccessTime: Long = System.currentTimeMillis, properties: Map[String, String] = Map.empty, viewOriginalText: Option[String] = None, - viewText: Option[String] = None) { + viewText: Option[String] = None, + comment: Option[String] = None) { --- End diff -- I actually prefer to keep it as comment because it's `COMMENT` in the query and `"comment"` in Hive's table properties
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org