Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12247#discussion_r59295994
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala ---
    @@ -129,8 +129,17 @@ trait SchemaRelationProvider {
      * Implemented by objects that can produce a streaming [[Source]] for a 
specific format or system.
      */
     trait StreamSourceProvider {
    +
    +  /** Returns the name and schema of the source that can be used to 
continually read data. */
    +  def sourceSchema(
    +      sqlContext: SQLContext,
    +      schema: Option[StructType],
    +      providerName: String,
    +      parameters: Map[String, String]): (String, StructType)
    +
       def createSource(
           sqlContext: SQLContext,
    +      sourceId: Long,
    --- End diff --
    
    Why are we passing the `sourceId` instead of the location?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to