Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12314#discussion_r59313257
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
    @@ -66,8 +65,7 @@ private[spark] class HiveExternalCatalog(client: 
HiveClient) extends ExternalCat
         try {
           body
         } catch {
    -      case e: NoSuchItemException =>
    -        throw new AnalysisException(e.getMessage)
    +      case e: AnalysisException => throw new 
AnalysisException(e.getMessage)
    --- End diff --
    
    The effect of this is to lose the original stack trace and replace it with 
a new one here. Is that desirable vs just removing this line to let the 
original exception propagate?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to