Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r59319585
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -121,8 +123,13 @@ class SessionCatalog(
currentDb = db
}
- def getDefaultDBPath(db: String): String = {
- System.getProperty("java.io.tmpdir") + File.separator + db + ".db"
+ def getDatabasePath(dbName: String, path: Option[String]): String = {
+ val dbPath =
+ path.map(new Path(_))
+ .getOrElse(
+ new Path(new Path(System.getProperty("java.io.tmpdir")),
dbName.toLowerCase() + ".db"))
+ val dbLocation = dbPath.toString
+ if (dbLocation.endsWith(File.separator)) dbLocation.dropRight(1) else
dbLocation
--- End diff --
Actually, `getDatabasePath` in `SessionCatalog.scala` is not used. We are
not creating any physical directory for this. Thus, I assume here the directory
path is based on the OS platform. Personally, I think this should return an
empty string.
In `HiveSessionCatalog`, what we did is based on Hadoop FS interface.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
