Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12079#discussion_r59338971
--- Diff: python/pyspark/ml/feature.py ---
@@ -512,14 +512,19 @@ class HashingTF(JavaTransformer, HasInputCol,
HasOutputCol, HasNumFeatures, Java
.. versionadded:: 1.3.0
"""
+ binary = Param(Params._dummy(), "binary", "If true, all non zero
counts are set to 1. " +
+ "This is useful for discrete probabilistic models that
model binary events " +
+ "rather than integer counts. (default: False)",
--- End diff --
The style seems to be `. Default False` rather than `. (default: False)`.
@BryanCutler @holdenk thoughts?
Though I must say I'd prefer `(default: X).` across the board myself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
