GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/12327
[SPARK-14558][CORE] In ClosureCleaner, clean the outer pointer if it's a
REPL line object
## What changes were proposed in this pull request?
When we clean a closure, if its outermost parent is not a closure, we won't
clone and clean it as cloning user's objects is dangerous. However, if it's a
REPL line object, which may carry a lot of unnecessary references(like hadoop
conf, spark conf, etc.), we should clean it as it's not a user object.
This PR improves the check for user's objects to exclude REPL line object.
## How was this patch tested?
existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloud-fan/spark closure
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12327.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12327
----
commit b78b2cef91a07784e2c92bb266585af4e2df9896
Author: Wenchen Fan <wenc...@databricks.com>
Date: 2016-04-12T12:33:45Z
clean the outer pointer if it's a REPL line object
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
