GitHub user bomeng opened a pull request:
https://github.com/apache/spark/pull/12347
[SPARK-14441] [SQL] Consolidate DDL tests
## What changes were proposed in this pull request?
Today we have `DDLSuite`, `DDLCommandSuite`, `HiveDDLCommandSuite` and
`HiveDDLSuite`. In this PR, I am trying to consolidate the files as much as
possible. Two files are left for now, since it is good to put Hive related test
suite in the Hive package.
Along with the combination, I also did some modification of current codes
mainly in order to improve the codings, here is the summary:
1. Use `.contains()` instead `==` for Options, this method is introduced in
Scala 2.11 and it is recommended method to use for this purpose;
2. Make map consistent to use `->`, instead of 2 elements tuple;
3. Use `isEmpty()` instead of `== None`
4. Add `private` to the parser and narrow the scope of implicit (put inside
one of the tests);
5. Modify the names of some tests to be unique, since they are in one file
now;
## How was this patch tested?
I did not change the logic of any tests, just move around and improve the
codes, so existing test cases should remain same.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bomeng/spark SPARK-14441
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12347.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12347
----
commit af298b63693586e7c0598ccd98ba3f9e6a7634f7
Author: bomeng <bm...@us.ibm.com>
Date: 2016-04-13T02:19:27Z
Consolidate DDL tests
commit 06c8948b20cacccead019e42e3a07b89f727893a
Author: bomeng <bm...@us.ibm.com>
Date: 2016-04-13T02:21:52Z
remove extra line
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
