Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12342#discussion_r59487580
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ---
    @@ -975,6 +939,73 @@ object PushPredicateThroughAggregate extends 
Rule[LogicalPlan] with PredicateHel
           } else {
             filter
           }
    +
    +    case filter @ Filter(condition, u: Union) =>
    --- End diff --
    
    "non-determinstic" means the condition has internal state and may change 
every time it processes an input row. Before push down, we have only one 
stateful condition that processes all output rows of `Union`. But if we push it 
down, then each child of `Union` will have a stateful condition, I think it's 
different than before.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to