Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12353#discussion_r59506777
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -52,6 +52,8 @@ case class ExprCode(var code: String, var isNull: String,
var value: String)
*/
class CodegenContext {
+ var conf: CatalystConf = null
--- End diff --
this is really hacky -- i'd put this in the constructor and make it a val
rather than a var. and maybe we can create a CodegenConf instead of reusing
CatalystConf?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
