Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12334#discussion_r59610525
  
    --- Diff: assembly/pom.xml ---
    @@ -20,7 +20,7 @@
       <modelVersion>4.0.0</modelVersion>
       <parent>
         <groupId>org.apache.spark</groupId>
    -    <artifactId>spark-parent_2.11</artifactId>
    +    <artifactId>spark-parent</artifactId>
    --- End diff --
    
    Based on some of the comments in 
https://issues.apache.org/jira/browse/MNG-2971, 
https://issues.apache.org/jira/browse/MNG-4223, and other tickets I believe 
that the intent is that properties should be expanded when installing / 
deploying POMs.
    
    It looks like a somewhat more explicit way of ensuring this expansion would 
be to use the http://www.mojohaus.org/flatten-maven-plugin/ plugin.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to