Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12222#discussion_r59634825
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -409,6 +409,25 @@ class SessionCatalog(
}
/**
+ * Returns the partition names from catalog for a given table in a
database.
+ */
+ def getPartitionNames(db: String, table: String, range: Short):
Seq[String] = {
+ externalCatalog.getPartitionNames(db, table, range)
+ }
+
+ /**
+ * Returns the partition names that matche the partition spec for a
given table in a database.
+ * When no match is found, an empty Sequence is returned.
+ */
+ def getPartitionNames(
--- End diff --
I think a better API is:
```
def listPartitions(
db: String,
table: String,
partialSpec: Option[TablePartitionSpec]): Seq[CatalogTablePartition]
```
Note that we already have a `listPartitions`, but it doesn't allow us to
match anything. Once we have this we can do the formatting ourselves in the
`ShowPartitions` DDL. This leads to a more consistent catalog API and allows us
to provide a less awkward implementation in `InMemoryCatalog`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
