Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12389#issuecomment-209866605
LGTM. It's good practice to make method return types explicit, especially
if they're to be implemented in other classes. This should not change any
behavior since it just makes the implicit "Unit" return type explicit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
