Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12246#discussion_r59763010
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StreamTest.scala ---
    @@ -75,6 +76,8 @@ trait StreamTest extends QueryTest with Timeouts {
       /** How long to wait for an active stream to catch up when checking a 
result. */
       val streamingTimeout = 10.seconds
     
    +  val outputMode: OutputMode = Append
    --- End diff --
    
    We might want to make this an argument to `streamTest` with a default.  I 
think in a single suite we might want to be able to have more than one kind of 
test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to