Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12157#discussion_r59787409
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Split.scala ---
@@ -145,6 +147,11 @@ final class CategoricalSplit private[ml] (
private def setComplement(cats: Set[Double]): Set[Double] = {
Range(0, numCategories).map(_.toDouble).filter(cat =>
!cats.contains(cat)).toSet
}
+
+ override def hashCode(): Int = {
+ val state = Seq(isLeft, categories, featureIndex, numCategories)
--- End diff --
This could go near `equals`. You're using an extra field not used in
equals. It may work out OK but maybe easier to make them match.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
