Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12340#discussion_r59828693 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercionSuite.scala --- @@ -348,6 +350,20 @@ class HiveTypeCoercionSuite extends PlanTest { test("type coercion for If") { val rule = HiveTypeCoercion.IfCoercion + + // SPARK-14580 Hive IfCoercion should preserve predicate + case class AssertTrue(condition: Boolean) extends LeafExpression { --- End diff -- Right. That'll be much better.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org