Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/12413#discussion_r59851195 --- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala --- @@ -149,8 +149,8 @@ case class ExceptionFailure( this(e, accumUpdates, preserveCause = true) } - def exception: Option[Throwable] = exceptionWrapper.flatMap { - (w: ThrowableSerializationWrapper) => Option(w.exception) + def exception: Option[Throwable] = exceptionWrapper.flatMap { w => --- End diff -- Question: in this case, it could even be `flatMap(w => Option(w.exception))`. Is this different at all as far as Scala is concerned, without the braces at all? I could look it up but figured you might already know.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org