Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12105#discussion_r59864421
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -368,7 +369,10 @@ abstract class UnixTime extends BinaryExpression with
ExpectsInputTypes {
t.asInstanceOf[Long] / 1000000L
case StringType if right.foldable =>
if (constFormat != null) {
- Try(new SimpleDateFormat(constFormat.toString).parse(
+ if (formatter == null) {
+ formatter = Try(new
SimpleDateFormat(constFormat.toString)).getOrElse(null)
--- End diff --
`.orNull` is available? but, this will just cause an NPE in the next line,
which will also get squashed. Do we really want to hide both of these? why not
let the error fly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
