Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1673#discussion_r15630991
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -598,9 +598,12 @@ object DecisionTree extends Serializable with Logging {
// Find feature bins for all nodes at a level.
val binMappedRDD = input.map(x => findBinsForLevel(x))
- def updateBinForOrderedFeature(arr: Array[Double], agg: Array[Double],
nodeIndex: Int,
- label: Double, featureIndex: Int) = {
-
+ def updateBinForOrderedFeature(
+ arr: Array[Double],
+ agg: Array[Double],
+ nodeIndex: Int,
+ label: Double,
+ featureIndex: Int) = {
--- End diff --
Tiny note: I think this syntax for methods returning Unit is discouraged.
Martin himself mentions this
(http://www.parleys.com/play/51c1994ae4b0d38b54f4621b/chapter46/agenda) I had
the impression Spark was using `= {` for these methods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
