Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12273#issuecomment-211075866
OK, so the changes are to pull the check for the active context out of the
block checking for context being created (which looks like a simple bug), and
you also put the check for active context first. I suppose it really doesn't
matter which is checked first in this block. One generates a warning, one
generates the exception, so the behavior is the same. LGTM. I think the slight
code simplification you added is also warranted.
I think the tests are failing now for unrelated reasons but we can retest
soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
