Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11152#discussion_r60086938
  
    --- Diff: docs/monitoring.md ---
    @@ -269,17 +310,23 @@ for a running application, at 
`http://localhost:4040/api/v1`.
         <td>Details for the storage status of a given RDD</td>
       </tr>
       <tr>
    -    <td><code>/applications/[app-id]/logs</code></td>
    -    <td>Download the event logs for all attempts of the given application 
as a zip file</td>
    +    <td><code>/applications/[base-app-id]/logs</code></td>
    +    <td>Download the event logs for all attempts of the given application 
as a zip file.
    +    </td>
       </tr>
       <tr>
    -    <td><code>/applications/[app-id]/[attempt-id]/logs</code></td>
    -    <td>Download the event logs for the specified attempt of the given 
application as a zip file</td>
    +    <td><code>/applications/[base-app-id]/[attempt-id]/logs</code></td>
    +    <td>Download the event logs for a specific application as a zip 
file</td>
    --- End diff --
    
    I think the idea is that in all other cases `[app-id]` *must* include the 
attempt-id when applicable as well.  However `/logs` is special, in that even 
if there are multiple attempts, there is still an end-point with just 
base-app-id for getting logs from all attempts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to