Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12473#discussion_r60098422
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -356,8 +361,8 @@ private[spark] class Client(
logInfo("Preparing resources for our AM container")
// Upload Spark and the application JAR to the remote file system if
necessary,
// and add them as local resources to the application master.
- val fs = FileSystem.get(hadoopConf)
- val dst = getAppStagingDirPath(sparkConf, fs, appStagingDir)
+ val dst = new Path(appStagingBaseDir, appStagingDir)
--- End diff --
You could pass `appStagingDir` as a `Path` to this method and save some
duplication; same for `setupLaunchEnv` below.
This whole class could use some cleanup in that regard, but these two are
pretty low-hanging fruit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
