Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12423#discussion_r60161650
--- Diff:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolverSuite.java
---
@@ -118,27 +112,6 @@ public void testSortShuffleBlocks() throws IOException
{
}
@Test
- public void testHashShuffleBlocks() throws IOException {
- ExternalShuffleBlockResolver resolver = new
ExternalShuffleBlockResolver(conf, null);
--- End diff --
If I'm not mistaken, I think that this code path is exercised by the
external shuffle service, so a Spark 2.x shuffle service would be unable to
serve shuffle files generated by Spark 1.x when using hash shuffle.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
