Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/12435#discussion_r60163275 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -443,6 +443,26 @@ object SQLConf { .booleanConf .createWithDefault(false) + val FILE_STREAM_SINK_LOG_DELETE = SQLConfigBuilder("spark.sql.streaming.fileSink.log.deletion") + .internal() + .doc("Whether to delete the expired log files in file stream sink.") + .booleanConf + .createWithDefault(true) + + val FILE_STREAM_SINK_LOG_COMPACT_LEN = + SQLConfigBuilder("spark.sql.streaming.fileSink.log.compactLen") + .internal() + .doc("Every how many log files is a compaction triggered.") + .intConf + .createWithDefault(10) + + val FILE_STREAM_SINK_LOG_EXPIRED_TIME = + SQLConfigBuilder("spark.sql.streaming.fileSink.log.expired") + .internal() + .doc("How long in milliseconds a file is guaranteed to be visible for all readers.") + .longConf --- End diff -- This should be a `timeConf` isnt it ? Then any one can use "1 second", "1 minute".
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org