Github user BenFradet commented on a diff in the pull request:
https://github.com/apache/spark/pull/12467#discussion_r60255560
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/RFormulaSuite.scala ---
@@ -290,4 +291,18 @@ class RFormulaSuite extends SparkFunSuite with
MLlibTestSparkContext with Defaul
val newModel = testDefaultReadWrite(model)
checkModelData(model, newModel)
}
+
+ test("should support all NumericType labels") {
--- End diff --
Or simply just:
```scala
val schema = dataset.schema
SchemaUtils.checkNumericType(schema, $(labelCol))
```
at the beginning of RFormula's `fit` method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
