Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12493#discussion_r60309791
  
    --- Diff: R/pkg/inst/worker/worker.R ---
    @@ -84,6 +84,10 @@ broadcastElap <- elapsedSecs()
     # as number of partitions to create.
     numPartitions <- SparkR:::readInt(inputCon)
     
    +# If true, working for RDD
    +# If false, working for DataFrame
    +isDataFrame <- as.logical(SparkR:::readInt(inputCon))
    --- End diff --
    
    this might be beyond the scope of this JIRA/PR: when we have protocol 
changes like this, how do we make sure the peer has matching implementation, 
and then we are not misinterpreting the byte streams? Should there be some sort 
of protocol version handshake?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to