Github user ericl commented on the pull request: https://github.com/apache/spark/pull/12490#issuecomment-212209007 It seems this is the failing test. @davies any idea why the decimal handling is wrong here? If I am understanding correctly when `dt.precision - dt.scale <= Decimal.MAX_LONG_DIGITS`, the unscaled long value should be enough for sorting. ``` [info] !0.9999999999999999999999999 2.9999999999999999999999997 1 3 [info] 1 3 1 3 [info] !1 3 0.9999999999999999999999999 2.9999999999999999999999997 ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org