Github user robbinspg commented on the pull request:
https://github.com/apache/spark/pull/12397#issuecomment-212358250
@hvanhovell Yes I will. I'm trying to get a stable base benchmark first as
running the ParquetReadBenchmark repeatedly against the base code (before
either PR) I get what looks like a 10% variation in results. The same is true
with either of the PRs applied so I will average out the runs.
As far as subclassing goes I would expect performance on LE to remain the
same as the code path should be identical once the classes are instantiated.
Performance on BE between the 2 approaches is another thing but not the major
concern at the moment as we are going from failing/exceptions thrown to
"working"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
