Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/1147#discussion_r15679079
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
@@ -106,38 +183,131 @@ class JoinSuite extends QueryTest {
}
test("left outer join") {
- checkAnswer(
- upperCaseData.join(lowerCaseData, LeftOuter, Some('n === 'N)),
- (1, "A", 1, "a") ::
- (2, "B", 2, "b") ::
- (3, "C", 3, "c") ::
- (4, "D", 4, "d") ::
- (5, "E", null, null) ::
- (6, "F", null, null) :: Nil)
+ lowerCaseData.registerAsTable("right")
+ upperCaseData.registerAsTable("left")
+ def run() {
+ checkAnswer(
+ left.join(right, LeftOuter, Some('n === 'N)),
+ (1, "A", 1, "a") ::
+ (2, "B", 2, "b") ::
+ (3, "C", 3, "c") ::
+ (4, "D", 4, "d") ::
+ (5, "E", null, null) ::
+ (6, "F", null, null) :: Nil)
+
+ checkAnswer(
+ left.join(right, LeftOuter, Some('n === 'N && 'n > 1)),
+ (1, "A", null, null) ::
+ (2, "B", 2, "b") ::
+ (3, "C", 3, "c") ::
+ (4, "D", 4, "d") ::
+ (5, "E", null, null) ::
+ (6, "F", null, null) :: Nil)
+
+ checkAnswer(
+ left.join(right, LeftOuter, Some('n === 'N && 'N > 1)),
+ (1, "A", null, null) ::
+ (2, "B", 2, "b") ::
+ (3, "C", 3, "c") ::
+ (4, "D", 4, "d") ::
+ (5, "E", null, null) ::
+ (6, "F", null, null) :: Nil)
+
+ checkAnswer(
+ left.join(right, LeftOuter, Some('n === 'N && 'l > 'L)),
+ (1, "A", 1, "a") ::
+ (2, "B", 2, "b") ::
+ (3, "C", 3, "c") ::
+ (4, "D", 4, "d") ::
+ (5, "E", null, null) ::
+ (6, "F", null, null) :: Nil)
+ }
+
+ check(run)
}
test("right outer join") {
- checkAnswer(
- lowerCaseData.join(upperCaseData, RightOuter, Some('n === 'N)),
- (1, "a", 1, "A") ::
- (2, "b", 2, "B") ::
- (3, "c", 3, "C") ::
- (4, "d", 4, "D") ::
- (null, null, 5, "E") ::
- (null, null, 6, "F") :: Nil)
+ lowerCaseData.registerAsTable("left")
+ upperCaseData.registerAsTable("right")
+
+ val left = UnresolvedRelation(None, "left", None)
+ val right = UnresolvedRelation(None, "right", None)
--- End diff --
Can't you just use upperCaseData and lowerCaseData here instead of creating
UnresolvedRelations for them and registering them and resolving them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
