Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/11746#issuecomment-212652411
@zsxwing I reverted back to the original thread logic, which was actually
fine and thread-safe - I just needed to move the `killed` flag to be set just
before killing the process, otherwise it is possible for the thread to finish
and set the final state, without knowing the process was killed. Now it is
possible that the shutdown hook could try to kill a process that is already
completed/terminated, but that is ok and doesn't cause an error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
