Github user davies commented on the pull request:

    https://github.com/apache/spark/pull/10024#issuecomment-212702206
  
    @lianhuiwang I don't think this is enough.
    
    If it's not easy to make it thread safe, one option could be not do forced 
spilling if spill() will called from another thread than the one consuming the 
iterator. At least it's better than before.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to